Update benchmarks in bench-vortex #5227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortsui20
added
changelog/performance
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: Random AccessSummary
|
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: GitHub Archive (NVMe)Summary
Detailed Results Table
|
Contributor
Benchmarks: GitHub Archive (S3)Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
AdamGS
reviewed
Nov 6, 2025
Comment on lines
+64
to
+70
| let state = black_box(setup()); | ||
| let elapsed = runtime.block_on(async { | ||
| let start = Instant::now(); | ||
| let output = routine(state).await; | ||
| let elapsed = start.elapsed(); | ||
| drop(black_box(output)); |
Contributor
There was a problem hiding this comment.
can you explain the use of black_box here?
Contributor
Author
There was a problem hiding this comment.
no idea... I'm going to test this locally first and I'll probably rewrite stuff
Contributor
Author
There was a problem hiding this comment.
ok its just because the function above uses it
Contributor
There was a problem hiding this comment.
We want bb in cause the compiler kills the call to routine() which does seem very unlikely
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
claude/modify-bench-vortex-011CUrsvv6nTLZmk8sxjdP3D
branch
from
d319b7e to
80844ab
Compare
Contributor
|
Any idea why we got a big tpc-h win? |
Comment on lines
+167
to
+180
| impl TimingMeasurement { | ||
| pub fn mean_time(&self) -> Duration { | ||
| let len = self.runs.len(); | ||
| if len == 0 { | ||
| vortex_panic!("cannot have no runs"); | ||
| } | ||
|
|
||
| let total_nanos: u128 = self.runs.iter().map(|d| d.as_nanos()).sum(); | ||
| let mean_nanos = total_nanos / len as u128; | ||
| Duration::new( | ||
| u64::try_from(mean_nanos / 1_000_000_000).vortex_unwrap(), | ||
| u32::try_from(mean_nanos % 1_000_000_000).vortex_unwrap(), | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
can we do median here
Contributor
Author
|
Closing in favor of #5234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5066
I had the claude code web do this so I have no idea if this works yetShould work...