Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 6, 2025

We were just deref'ing it to an array before!

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Nov 6, 2025
@gatesn gatesn enabled auto-merge (squash) November 6, 2025 00:50
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #5217 will degrade performances by 16.19%

Comparing ngates/remove-scope (dfb0210) with develop (28f5b3d)1

Summary

⚡ 43 improvements
❌ 59 regressions
✅ 1216 untouched
🆕 7 new
⏩ 155 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
decompress_alp[f32, (1000, 0.0, 0.25)] 12.1 µs 8.7 µs +39.55%
decompress_alp[f32, (1000, 0.0, 0.95)] 12.1 µs 8.7 µs +39.08%
decompress_alp[f32, (1000, 0.0, 1.0)] 11.5 µs 8.6 µs +32.83%
decompress_alp[f32, (1000, 0.01, 0.25)] 26.4 µs 11.9 µs ×2.2
decompress_alp[f32, (1000, 0.01, 0.95)] 26 µs 11.6 µs ×2.3
decompress_alp[f32, (1000, 0.01, 1.0)] 15.1 µs 11.4 µs +33.01%
decompress_alp[f32, (1000, 0.1, 0.25)] 26.2 µs 11.7 µs ×2.2
decompress_alp[f32, (1000, 0.1, 0.95)] 28.2 µs 13.3 µs ×2.1
decompress_alp[f32, (1000, 0.1, 1.0)] 16.2 µs 12.5 µs +28.99%
decompress_alp[f32, (10000, 0.0, 0.25)] 81.2 µs 27.4 µs ×3
decompress_alp[f32, (10000, 0.0, 0.95)] 81.1 µs 27.4 µs ×3
decompress_alp[f32, (10000, 0.0, 1.0)] 81 µs 27.2 µs ×3
decompress_alp[f32, (10000, 0.01, 0.25)] 97.2 µs 30.7 µs ×3.2
decompress_alp[f32, (10000, 0.01, 0.95)] 98.6 µs 31.4 µs ×3.1
decompress_alp[f32, (10000, 0.01, 1.0)] 85.7 µs 32.2 µs ×2.7
decompress_alp[f32, (10000, 0.1, 0.25)] 102.3 µs 34.1 µs ×3
decompress_alp[f32, (10000, 0.1, 0.95)] 119 µs 40.6 µs ×2.9
decompress_alp[f32, (10000, 0.1, 1.0)] 95.4 µs 40.8 µs ×2.3
decompress_alp[f64, (1000, 0.0, 0.25)] 16.8 µs 11.5 µs +46.57%
decompress_alp[f64, (1000, 0.0, 0.95)] 16.7 µs 11.6 µs +43.29%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. No successful run was found on develop (7dde2f4) during the generation of this report, so 28f5b3d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 155 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.86%. Comparing base (28f5b3d) to head (dfb0210).
⚠️ Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-layout/src/layouts/row_idx/mod.rs 50.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 14841c0 into develop Nov 6, 2025
38 of 39 checks passed
@gatesn gatesn deleted the ngates/remove-scope branch November 6, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants