Bind constant array

[gatesn]

No description provided.

[codspeed-hq]

CodSpeed Performance Report

Merging #5208 will improve performances by ×3.2

_{Comparing ngates/constant-bind (c350ca2) with develop (28f5b3d)¹}

Summary

⚡ 36 improvements
✅ 1282 untouched
🆕 7 new
⏩ 155 skipped²

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	decompress_alp[f32, (1000, 0.0, 0.25)]	12.1 µs	8.6 µs	+40.98%
⚡	decompress_alp[f32, (1000, 0.0, 0.95)]	12.1 µs	8.6 µs	+40.5%
⚡	decompress_alp[f32, (1000, 0.0, 1.0)]	11.5 µs	8.5 µs	+34.19%
⚡	decompress_alp[f32, (1000, 0.01, 0.25)]	26.4 µs	11.9 µs	×2.2
⚡	decompress_alp[f32, (1000, 0.01, 0.95)]	26 µs	11.6 µs	×2.3
⚡	decompress_alp[f32, (1000, 0.01, 1.0)]	15.1 µs	11.4 µs	+33.01%
⚡	decompress_alp[f32, (1000, 0.1, 0.25)]	26.2 µs	11.7 µs	×2.2
⚡	decompress_alp[f32, (1000, 0.1, 0.95)]	28.2 µs	13.3 µs	×2.1
⚡	decompress_alp[f32, (1000, 0.1, 1.0)]	16.2 µs	12.5 µs	+28.99%
⚡	decompress_alp[f32, (10000, 0.0, 0.25)]	81.2 µs	27.3 µs	×3
⚡	decompress_alp[f32, (10000, 0.0, 0.95)]	81.1 µs	27.3 µs	×3
⚡	decompress_alp[f32, (10000, 0.0, 1.0)]	81 µs	27.2 µs	×3
⚡	decompress_alp[f32, (10000, 0.01, 0.25)]	97.2 µs	30.7 µs	×3.2
⚡	decompress_alp[f32, (10000, 0.01, 0.95)]	98.6 µs	31.4 µs	×3.1
⚡	decompress_alp[f32, (10000, 0.01, 1.0)]	85.7 µs	32.2 µs	×2.7
⚡	decompress_alp[f32, (10000, 0.1, 0.25)]	102.3 µs	34 µs	×3
⚡	decompress_alp[f32, (10000, 0.1, 0.95)]	119 µs	40.6 µs	×2.9
⚡	decompress_alp[f32, (10000, 0.1, 1.0)]	95.4 µs	40.8 µs	×2.3
⚡	decompress_alp[f64, (1000, 0.0, 0.25)]	16.8 µs	11.4 µs	+47.69%
⚡	decompress_alp[f64, (1000, 0.0, 0.95)]	16.7 µs	11.5 µs	+44.38%
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

1. No successful run was found on develop (6e86418) during the generation of this report, so 28f5b3d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 155 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[joseph-isaacs]

vortex-dtype is the wrong place? Do you have a place of where to move this to at a later date?

[gatesn]

NativePType, NativeDecimalType, PValue (PScalar), DecimalValue (DScalar), and all associated macros should really live in vortex-vector. They're all physical.

[connortsui20]

I made this: #5209

[codecov]

Codecov Report

❌ Patch coverage is 30.76923% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.91%. Comparing base (28f5b3d) to head (c350ca2).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ortex-array/src/arrays/constant/vtable/operator.rs	0.00%	70 Missing ⚠️
vortex-vector/src/listview/vector_mut.rs	0.00%	6 Missing ⚠️
vortex-vector/src/primitive/generic_mut.rs	0.00%	6 Missing ⚠️
vortex-vector/src/bool/vector_mut.rs	0.00%	4 Missing ⚠️
vortex-vector/src/decimal/generic_mut.rs	95.00%	2 Missing ⚠️
vortex-vector/src/decimal/vector_mut.rs	50.00%	2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.