fix[vortex-expr]: delegate AnalysisExpr to CastExpr child #5179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checked_pruning_expr would otherwise return None which would result in no pruning using expressions that contained a CastExpr somewhere. It's relatively common for e.g. struct fields to be cast to the right type for comparison with literals by datafusion, and this expression translates to get_item(cast(struct), "field") = "value". This cast within a get_item would return None when field_path was called before this change. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
asubiotto
force-pushed
the
asubiotto/prunecast
branch
from
82c3db3 to
f2547de
Compare
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Nov 4, 2025
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
I think there's some extra pruning possible with cast expression but that's a more complicated rewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checked_pruning_expr would otherwise return None which would result in no pruning using expressions that contained a CastExpr somewhere. It's relatively common for e.g. struct fields to be cast to the right type for comparison with literals by datafusion, and this expression translates to get_item(cast(struct), "field") = "value". This cast within a get_item would return None when field_path was called before this change.