-
Notifications
You must be signed in to change notification settings - Fork 130
feat: into_struct_fields_* #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I find myself wanting this in Spiral. Is it reasonable? Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
|
why is the |
|
We maybe shouldn't do this but there's cases where I get an owned DType and I want to convert to a Spiral Schema which is a StructFields without nullability (b/c its a SQL-style table: no top-level nulls). |
|
I currently do |
CodSpeed Performance ReportMerging #5128 will not alter performanceComparing Summary
Footnotes
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this is fine, maybe we should add owned into_ variants for the other conversion methods too |
Signed-off-by: Daniel King <dan@spiraldb.com>
|
I added an |
Signed-off-by: Daniel King <dan@spiraldb.com>
|
all checks passing now. |
I find myself wanting this in Spiral. Is it reasonable?