Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Oct 30, 2025

Oof. Moving this type from vortex-scalar to vortex-dtype so we can use it in vortex-vector 😢

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from a10y October 30, 2025 01:33
@gatesn gatesn added the changelog/chore A trivial change label Oct 30, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) October 30, 2025 01:35
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2025

CodSpeed Performance Report

Merging #5120 will improve performances by 12.55%

Comparing ngates/decimal-vector (9fe0949) with develop (a0808e7)

Summary

⚡ 16 improvements
✅ 1302 untouched
🆕 7 new
⏩ 92 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
chunked_dict_primitive_canonical_into[f32, (1000, 10, 100)] 768.8 µs 698.4 µs +10.08%
chunked_dict_primitive_canonical_into[u32, (1000, 10, 100)] 789.7 µs 717.7 µs +10.04%
chunked_dict_primitive_canonical_into[u32, (1000, 100, 100)] 794.7 µs 721.9 µs +10.08%
chunked_dict_primitive_into_canonical[u32, (1000, 10, 100)] 792.7 µs 719.6 µs +10.17%
take_indices[(1000, 16, 0.005)] 22 µs 19.6 µs +12.25%
take_indices[(1000, 16, 0.01)] 22.2 µs 19.8 µs +12.01%
take_indices[(1000, 16, 0.03)] 23.9 µs 21.5 µs +11.17%
take_indices[(1000, 256, 0.005)] 21.8 µs 19.4 µs +12.55%
take_indices[(1000, 256, 0.01)] 22.1 µs 19.7 µs +12.24%
take_indices[(1000, 256, 0.03)] 22.4 µs 20.1 µs +11.84%
take_indices[(1000, 4, 0.005)] 24.4 µs 22 µs +11.09%
take_indices[(1000, 4, 0.01)] 24.9 µs 22.5 µs +10.56%
take_indices[(1000, 4, 0.03)] 26.2 µs 23.8 µs +10.12%
take_indices[(10000, 16, 0.005)] 25.6 µs 23.2 µs +10.38%
take_indices[(10000, 256, 0.005)] 24 µs 21.6 µs +10.99%
take_indices[(10000, 256, 0.01)] 26.1 µs 23.7 µs +10.16%
🆕 decompress[("alp_for_bp_f64", 0x75e5b0)] N/A 24.2 ms N/A
🆕 decompress[("datetime_for_bp", 0x761890)] N/A 34.9 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x7609a0)] N/A 14.5 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x760310)] N/A 14.5 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 92 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 9eeca48 into develop Oct 30, 2025
39 checks passed
@gatesn gatesn deleted the ngates/decimal-vector branch October 30, 2025 11:19
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 86.53846% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.23%. Comparing base (a0808e7) to head (9fe0949).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-dtype/src/decimal/types.rs 0.00% 6 Missing ⚠️
vortex-duckdb/src/exporter/decimal.rs 80.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants