Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Oct 29, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from robert3005 October 29, 2025 11:59
@gatesn gatesn added the changelog/feature A new feature label Oct 29, 2025
@gatesn gatesn requested a review from connortsui20 October 29, 2025 11:59
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) October 29, 2025 12:04
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 29, 2025

CodSpeed Performance Report

Merging #5110 will degrade performances by 10.02%

Comparing ngates/get-item (9c4193a) with develop (846f65f)

Summary

❌ 1 regression
✅ 1317 untouched
🆕 7 new
⏩ 50 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
decode_primitives[f32, (1000, 32)] 22.6 µs 25.1 µs -10.02%
🆕 decompress[("alp_for_bp_f64", 0x72f570)] N/A 24.2 ms N/A
🆕 decompress[("datetime_for_bp", 0x732850)] N/A 34.9 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x731960)] N/A 14.5 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x7312d0)] N/A 14.5 ms N/A
🆕 decompress[("dict_varbinview_string", 0x72ff90)] N/A 14.7 ms N/A
🆕 decompress[("for_bp_u64", 0x72ee20)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x730420)] N/A 2 ms N/A

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 80.51948% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.79%. Comparing base (846f65f) to head (9c4193a).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/compute/arrays/get_item.rs 82.75% 25 Missing ⚠️
vortex-array/src/compute/arrays/is_not_null.rs 0.00% 2 Missing ⚠️
vortex-dtype/src/dtype.rs 66.66% 2 Missing ⚠️
vortex-array/src/compute/arrays/is_null.rs 0.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit 797160d into develop Oct 29, 2025
63 of 65 checks passed
@gatesn gatesn deleted the ngates/get-item branch October 29, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants