Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Oct 25, 2025

Patches get filtered after the T::encode call in case they are null. Therefore patches-chunk-offsets need to be adjusted as part of filtering. Subject to be cleaned up in a follow up.

@0ax1 0ax1 requested a review from robert3005 October 25, 2025 09:34
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2025

CodSpeed Performance Report

Merging #5080 will improve performances by 11.06%

Comparing ad/fix-alp-patch-offsets (179d65e) with develop (2f09c15)

Summary

⚡ 1 improvement
✅ 1317 untouched
🆕 7 new
⏩ 8 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
new_bp_prim_test_between[i16, 32768] 120 µs 108 µs +11.06%
🆕 decompress[("alp_for_bp_f64", 0x6e2110)] N/A 24.2 ms N/A
🆕 decompress[("datetime_for_bp", 0x6e53f0)] N/A 34.9 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x6e4500)] N/A 14.5 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x6e3e70)] N/A 14.5 ms N/A
🆕 decompress[("dict_varbinview_string", 0x6e2b30)] N/A 14.7 ms N/A
🆕 decompress[("for_bp_u64", 0x6e19c0)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x6e2fc0)] N/A 2 ms N/A

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.42%. Comparing base (2f09c15) to head (179d65e).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/alp/src/alp/compress.rs 81.81% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 force-pushed the ad/fix-alp-patch-offsets branch from 151decd to 179d65e Compare October 25, 2025 09:59
@0ax1 0ax1 added the changelog/fix A bug fix label Oct 25, 2025
@0ax1
Copy link
Contributor Author

0ax1 commented Oct 25, 2025

Followed up by: #5065

@0ax1 0ax1 enabled auto-merge (squash) October 25, 2025 10:53
Copy link
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to rethink the compression flow here. It’s pretty convoluted

@0ax1 0ax1 merged commit bc47986 into develop Oct 25, 2025
44 of 45 checks passed
@0ax1 0ax1 deleted the ad/fix-alp-patch-offsets branch October 25, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants