Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/setup-rust/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ description: "Toolchain setup and Initial compilation"
inputs:
repo-token:
description: "GitHub token for accessing the repository (typically secrets.GITHUB_TOKEN)"
required: true
required: false
default: "${{ github.token }}"
toolchain:
description: "optional override for the toolchain version (e.g. nightly)"
required: false
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/bench-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- family=c6id.8xlarge
- image=ubuntu24-full-x64
- spot=false
- extras=s3-cache
- ${{ github.event.pull_request.head.repo.fork == false && 'extras=s3-cache' || '' }}
- tag=${{ matrix.benchmark.id }}
strategy:
matrix:
Expand All @@ -46,6 +46,7 @@ jobs:
if: ${{ contains(github.event.head_commit.message, '[benchmark]') || github.event.label.name == 'benchmark' && github.event_name == 'pull_request' }}
steps:
- uses: runs-on/action@v2
if: github.event.pull_request.head.repo.fork == false
with:
sccache: s3
- uses: actions/checkout@v5
Expand All @@ -69,6 +70,7 @@ jobs:
cargo build --bin ${{ matrix.benchmark.id }} --package bench-vortex --profile release_debug

- name: Setup Polar Signals
if: github.event.pull_request.head.repo.fork == false
uses: polarsignals/gh-actions-ps-profiling@v0.6.0
with:
polarsignals_cloud_token: ${{ secrets.POLAR_SIGNALS_API_KEY }}
Expand All @@ -85,6 +87,7 @@ jobs:
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o ${{ matrix.benchmark.id }}.json

- name: Setup AWS CLI
if: github.event.pull_request.head.repo.fork == false
uses: aws-actions/configure-aws-credentials@v5
with:
role-to-assume: arn:aws:iam::375504701696:role/GitHubBenchmarkRole
Expand All @@ -108,7 +111,7 @@ jobs:
| jq -r '.workflow_runs[].head_sha' \
)

aws s3 cp s3://vortex-benchmark-results-database/data.json.gz - \
aws s3 cp s3://vortex-benchmark-results-database/data.json.gz - --no-sign-request \
| gzip -d \
| grep $base_commit_sha \
> base.json
Expand Down
21 changes: 12 additions & 9 deletions .github/workflows/sql-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,11 @@ jobs:
- family=${{ inputs.machine_type }}
- image=ubuntu24-full-x64
- spot=false
- extras=s3-cache
- ${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && 'extras=s3-cache' || '' }}
- tag=${{ matrix.id }}
steps:
- uses: runs-on/action@v2
if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
with:
sccache: s3
- uses: actions/checkout@v5
Expand Down Expand Up @@ -158,13 +159,14 @@ jobs:
-d gh-json ${{ matrix.scale_factor }}

- name: Setup AWS CLI
if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
uses: aws-actions/configure-aws-credentials@v5
with:
role-to-assume: arn:aws:iam::375504701696:role/GitHubBenchmarkRole
aws-region: us-east-1

- name: Upload data
if: matrix.remote_storage != null
if: matrix.remote_storage != null && (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false)
shell: bash
env:
AWS_REGION: "eu-west-1"
Expand All @@ -173,6 +175,7 @@ jobs:
aws s3 cp --recursive ${{matrix.local_dir}} ${{ matrix.remote_storage }}

- name: Setup Polar Signals
if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
uses: polarsignals/gh-actions-ps-profiling@v0.6.0
with:
polarsignals_cloud_token: ${{ secrets.POLAR_SIGNALS_API_KEY }}
Expand All @@ -182,13 +185,13 @@ jobs:
extra_args: "--off-cpu-threshold=0.001" # Personally tuned by @brancz

- name: Run ${{ matrix.name }} benchmark
if: matrix.remote_storage == null
if: matrix.remote_storage == null || github.event.pull_request.head.repo.fork == true
shell: bash
env:
OTEL_SERVICE_NAME: "vortex-bench"
OTEL_EXPORTER_OTLP_PROTOCOL: "http/protobuf"
OTEL_EXPORTER_OTLP_ENDPOINT: "${{ secrets.OTEL_EXPORTER_OTLP_ENDPOINT }}"
OTEL_EXPORTER_OTLP_HEADERS: "${{ secrets.OTEL_EXPORTER_OTLP_HEADERS }}"
OTEL_EXPORTER_OTLP_ENDPOINT: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_ENDPOINT || '' }}"
OTEL_EXPORTER_OTLP_HEADERS: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_HEADERS || '' }}"
OTEL_RESOURCE_ATTRIBUTES: "bench-name=${{ matrix.id }}"
run: |
target/release_debug/query_bench ${{ matrix.subcommand }} \
Expand All @@ -200,14 +203,14 @@ jobs:
-o results.json

- name: Run ${{ matrix.name }} benchmark (remote)
if: matrix.remote_storage != null
if: matrix.remote_storage != null && (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false)
shell: bash
env:
AWS_REGION: "eu-west-1"
OTEL_SERVICE_NAME: "vortex-bench"
OTEL_EXPORTER_OTLP_PROTOCOL: "http/protobuf"
OTEL_EXPORTER_OTLP_ENDPOINT: "${{ secrets.OTEL_EXPORTER_OTLP_ENDPOINT }}"
OTEL_EXPORTER_OTLP_HEADERS: "${{ secrets.OTEL_EXPORTER_OTLP_HEADERS }}"
OTEL_EXPORTER_OTLP_ENDPOINT: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_ENDPOINT || '' }}"
OTEL_EXPORTER_OTLP_HEADERS: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_HEADERS || '' }}"
OTEL_RESOURCE_ATTRIBUTES: "bench-name=${{ matrix.id }}"
run: |
target/release_debug/query_bench ${{ matrix.subcommand }} \
Expand Down Expand Up @@ -239,7 +242,7 @@ jobs:
| jq -r '.workflow_runs[].head_sha' \
)

aws s3 cp s3://vortex-benchmark-results-database/data.json.gz - \
aws s3 cp s3://vortex-benchmark-results-database/data.json.gz - --no-sign-request \
| gzip -d \
| grep $base_commit_sha \
> base.json
Expand Down
Loading