Skip to content

Conversation

@connortsui20
Copy link
Contributor

oops

@connortsui20 connortsui20 added the changelog/fix A bug fix label Oct 16, 2025
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/fix-lance-feature-clickbench-nightly branch from 34f566f to 03c4edb Compare October 16, 2025 22:02
@connortsui20 connortsui20 enabled auto-merge (squash) October 16, 2025 22:06
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #4976 will improve performances by 11.42%

Comparing ct/fix-lance-feature-clickbench-nightly (03c4edb) with develop (fe8594d)1

Summary

⚡ 18 improvements
✅ 1290 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
decode_primitives[f32, (1000, 128)] 25.6 µs 23.2 µs +10.23%
decode_primitives[f32, (1000, 2)] 25.6 µs 23.2 µs +10.24%
decode_primitives[f32, (1000, 32)] 25.5 µs 23.1 µs +10.29%
decode_primitives[f32, (1000, 4)] 25.7 µs 23.3 µs +10.2%
decode_primitives[f32, (1000, 8)] 25.7 µs 23.3 µs +10.19%
decode_primitives[u8, (1000, 128)] 26.2 µs 23.8 µs +10.14%
decode_primitives[u8, (1000, 32)] 26.2 µs 23.8 µs +10.15%
decode_primitives[u8, (1000, 4)] 26.2 µs 23.8 µs +10.15%
decode_primitives[u8, (1000, 512)] 26.3 µs 23.9 µs +10.1%
decode_primitives[u8, (1000, 8)] 26.2 µs 23.8 µs +10.15%
take_indices[(1000, 16, 0.005)] 23.1 µs 20.8 µs +11.01%
take_indices[(1000, 16, 0.01)] 22.9 µs 20.5 µs +11.27%
take_indices[(1000, 16, 0.03)] 24.5 µs 22.2 µs +10.45%
take_indices[(1000, 256, 0.005)] 22.4 µs 20.1 µs +11.36%
take_indices[(1000, 256, 0.01)] 22.6 µs 20.3 µs +11.42%
take_indices[(1000, 256, 0.03)] 23.1 µs 20.8 µs +11.13%
take_indices[(1000, 4, 0.01)] 24.3 µs 22 µs +10.54%
take_indices[(10000, 256, 0.005)] 24.5 µs 22.2 µs +10.43%

Footnotes

  1. No successful run was found on develop (f2fd779) during the generation of this report, so fe8594d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@connortsui20 connortsui20 merged commit 32f3f67 into develop Oct 16, 2025
40 checks passed
@connortsui20 connortsui20 deleted the ct/fix-lance-feature-clickbench-nightly branch October 16, 2025 22:14
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.23%. Comparing base (d0b49b1) to head (03c4edb).
⚠️ Report is 2 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants