feat: teach merge to optionally error on duplicates #4971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error on duplicates is better for new users who accidentally collide names. Signed-off-by: Daniel King <dan@spiraldb.com>
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #[default] | ||
| RightMost, | ||
| /// If two structs share a field name, error. | ||
| Error, |
robert3005
reviewed
Oct 17, 2025
robert3005
reviewed
Oct 17, 2025
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
robert3005
approved these changes
Oct 18, 2025
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
left one small comment
vortex-expr/src/exprs/merge.rs
Outdated
| if !dtype.is_struct() { | ||
| for expr in expr.values.iter() { | ||
| let dtype = expr.return_dtype(scope)?; | ||
| let Some(fields) = dtype.as_struct_fields_opt().cloned() else { |
Contributor
There was a problem hiding this comment.
You likely don't need the clone here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error on duplicates is better for new users who accidentally collide names.