Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Oct 15, 2025

Note that the micro-benchmarks in take_patches.rs "regress" as we increase the array size to 65536.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from robert3005 October 15, 2025 14:50
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #4951 will degrade performances by 77.91%

Comparing ad/patches-constant-time-take (87d6278) with develop (a388bf1)

Summary

❌ 32 regressions
✅ 1250 untouched
🆕 16 new

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
take_map[(0.005, 0.05)] 43.6 µs 112.9 µs -61.37%
take_map[(0.005, 0.1)] 63.6 µs 183.9 µs -65.42%
take_map[(0.005, 0.5)] 202.2 µs 736.2 µs -72.54%
take_map[(0.005, 1.0)] 374.5 µs 1,460.5 µs -74.36%
take_map[(0.01, 0.05)] 51.8 µs 129.8 µs -60.09%
take_map[(0.01, 0.1)] 68.1 µs 201.6 µs -66.2%
take_map[(0.01, 0.5)] 213.8 µs 764.4 µs -72.03%
take_map[(0.01, 1.0)] 390.4 µs 1,465.5 µs -73.36%
take_map[(0.05, 0.05)] 83.3 µs 259.1 µs -67.85%
take_map[(0.05, 0.1)] 106.1 µs 340.7 µs -68.86%
take_map[(0.05, 0.5)] 283.6 µs 1,012.9 µs -72%
take_map[(0.05, 1.0)] 487.8 µs 1,872.9 µs -73.95%
take_map[(0.1, 0.05)] 123.5 µs 420 µs -70.58%
take_map[(0.1, 0.1)] 147.7 µs 515.2 µs -71.33%
take_map[(0.1, 0.5)] 323.5 µs 1,276.5 µs -74.65%
take_map[(0.1, 1.0)] 578.7 µs 2,271.5 µs -74.52%
take_search[(0.005, 0.05)] 49.6 µs 165.3 µs -70%
take_search[(0.005, 0.1)] 82.8 µs 305.1 µs -72.87%
take_search[(0.005, 0.5)] 325.4 µs 1,419.6 µs -77.08%
take_search[(0.005, 1.0)] 630 µs 2,808.6 µs -77.57%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.01%. Comparing base (d37444a) to head (87d6278).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/patches.rs 88.00% 24 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 added the changelog/feature A new feature label Oct 15, 2025
@0ax1 0ax1 marked this pull request as ready for review October 15, 2025 15:48
0ax1 added 2 commits October 15, 2025 16:54
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 enabled auto-merge (squash) October 15, 2025 16:12
@0ax1 0ax1 merged commit 839b7dd into develop Oct 15, 2025
38 of 39 checks passed
@0ax1 0ax1 deleted the ad/patches-constant-time-take branch October 15, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants