Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Oct 15, 2025

No description provided.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from gatesn and robert3005 October 15, 2025 14:30
@AdamGS AdamGS added the changelog/fix A bug fix label Oct 15, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #4950 will degrade performances by 10.48%

Comparing adamg/binary-operator-return-dtype (719d421) with develop (64487cc)

Summary

❌ 1 regression
✅ 1281 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
encode_specialized 1.1 ms 1.2 ms -10.48%

@AdamGS AdamGS merged commit a388bf1 into develop Oct 15, 2025
40 of 41 checks passed
@AdamGS AdamGS deleted the adamg/binary-operator-return-dtype branch October 15, 2025 15:04
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.01%. Comparing base (64487cc) to head (719d421).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-expr/src/exprs/binary.rs 33.33% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants