fix: match_between rewriting #4945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ) { | ||
| (true, false) => lhs.clone(), | ||
| (false, true) => BinaryExpr::new(lhs.rhs().clone(), lhs.op().swap()?, lhs.lhs().clone()), | ||
| _ => return None, |
Contributor
There was a problem hiding this comment.
I assume that a variable could be between two other variables?
a <= x <= b
Contributor
Author
There was a problem hiding this comment.
This function only does the rewrite if it's variable between two lits
Contributor
There was a problem hiding this comment.
I see, I guess we can leave it like than, but there is not reason this needs to be the case
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/between-bug
branch
from
891d8d3 to
221b7cd
Compare
a10y
commented
Oct 14, 2025
| _ => return None, | ||
| }; | ||
|
|
||
| let (left, left_op, right, right_op) = if left_lit.value() > right_lit.value() { |
Contributor
Author
There was a problem hiding this comment.
this was the bad piece
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while fuzzing, the failure was
Was confused how the expression was getting reverse. The previous logic was just discarding information and picking the larger lit as the upper bound. This version should be more robust.
I've added a unit test for this case, it fails with the old version of
find_betweenand succeeds now. I've also confirmed my fuzz artifact succeeds when I run with new code: