fix[vortex-{scan,io,datafusion}]: propagate tracing spans #4939
Conversation
AdamGS
left a comment
AdamGS
left a comment
There was a problem hiding this comment.
LGTM. The next major DataFusion release will expose its tracing API which will make the vortex-datafusion side of this use that, but as we already have tracing wired in a few places this probably an improvement.
|
|
||
| Ok(stream) | ||
| } | ||
| .instrument(tracing::Span::current()) |
There was a problem hiding this comment.
Done! Forgot about this one, thanks.
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change correctly connects object storage spans with the expected parent spans. Previously, object store spans were orphaned. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
asubiotto
force-pushed
the
asubiotto/tracingscan
branch
from
6961016 to
e01095a
Compare
TIL |
|
They hide it pretty well 😅, I would've loved if the whole ecosystem used |
Maybe one day, but I wouldn't hold my breath. Tracing, regardless of language, always feels (unfortunately) like an afterthought. |
This change correctly connects object storage spans with the expected parent spans. Previously, object store spans were orphaned.