Chore: Clean up benchmarks website #4921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Oct 11, 2025
Deploying vortex-bench with
|
| Latest commit: |
3f29072
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bbad23f8.vortex-93b.pages.dev |
| Branch Preview URL: | https://ct-hide-lance.vortex-93b.pages.dev |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/hide-lance
branch
from
417daba to
657d60d
Compare
connortsui20
changed the title
Get latest benchmark results per target instead of per commit. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
changed the title
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Contributor
|
I am surprised we don't see some negative lines here. We rewrote the handling but old code should be removed? I doubt we just added 3k lines here |
The modular system was added but never actually used in production. It added 3,275 lines of dead code that only increased bundle size. Keeping only the essential bug fixes: - scoring.js: Fixed to handle missing benchmark data - data-shared.js: Fixed case-sensitivity in renaming - index.html: Lance hiding configuration Removed: - 14 unused modular system files (2,657 lines) - Test and example files that shouldn't be in production (618 lines) Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Contributor
Author
|
Turns out it was just a lot of dead code |
robert3005
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because lance is so much slower in some of the queries than every other target, it makes a lot of charts harder to see everything.
EDIT: They are actually not showing up at all on the TPCH
EDIT AGAGIN: I'm going to use this PR to fix the two other problems. The first is that because we do not run lance on every PR the summaries will disappear. The second is that TPC-H queries are not showing up.