-
Notifications
You must be signed in to change notification settings - Fork 130
feat: constant time patches slicing #4913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
42c800f to
02d8378
Compare
CodSpeed Performance ReportMerging #4913 will degrade performances by 22.13%Comparing Summary
Benchmarks breakdown
|
Benchmarks: FineWebSummary
Detailed Results Table
|
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
02d8378 to
3a19857
Compare
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
3a19857 to
5076f34
Compare
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
done |
Deploying vortex-bench with
|
| Latest commit: |
ab63be9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://743f072b.vortex-93b.pages.dev |
| Branch Preview URL: | https://ad-patches-no-search-sorted.vortex-93b.pages.dev |
robert3005
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's some style comments and one case that I think is not being handled
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
c143ecf to
4e4729c
Compare
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
d9c5f12 to
95c04fc
Compare
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Follow up PRs will address
take,filterandmask, as well as chunk offset construction in ALP.