Propegate output_ordering to scan #4909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/df-testing-ordering
branch
from
0660004 to
8ed78b5
Compare
AdamGS
commented
Oct 10, 2025
| │ └── Root | ||
| └── pattern: Literal(value: "test%", dtype: utf8) | ||
| "#); | ||
| insta::allow_duplicates! { |
Contributor
Author
There was a problem hiding this comment.
This makes cargo test -p vortex-datafusion work
AdamGS
commented
Oct 10, 2025
Comment on lines
+242
to
+252
| ┌───────────────────────────┐ | ||
| │ SortPreservingMergeExec │ | ||
| │ -------------------- │ | ||
| │ c1 ASC NULLS LASTlimit: │ | ||
| │ 3 │ | ||
| └─────────────┬─────────────┘ | ||
| ┌─────────────┴─────────────┐ | ||
| │ DataSourceExec │ | ||
| │ -------------------- │ | ||
| │ files: 3 │ | ||
| │ format: vortex │ | ||
| └───────────────────────────┘ | ||
| "); |
Contributor
Author
There was a problem hiding this comment.
Shows plan is correct - it has no explicit SortExec node.
AdamGS
force-pushed
the
adamg/df-testing-ordering
branch
from
8ed78b5 to
df5a00b
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/df-testing-ordering
branch
from
df5a00b to
3f8b239
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where datafusion scans the provide
output_orderingassume the stream itself is provided in-order, and we explicitly don't guarantee the stream we return from files is in-order.