feat: add concat expression to vortex-expr #4902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `concat` expression that concatenates multiple expressions of the same type into a single ChunkedArray. Each input expression becomes a chunk in the resulting ChunkedArray. Features: - Validates all child expressions have the same dtype - Returns a ChunkedArray with each child as a chunk - Comprehensive tests covering various usage patterns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: blaginin <dima@spiraldb.com>
Signed-off-by: blaginin <dima@spiraldb.com>
CodSpeed Performance ReportMerging #4902 will degrade performances by 10.68%Comparing Summary
Benchmarks breakdown
Footnotes |
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vortex-expr/src/exprs/concat.rs
Outdated
|
|
||
| vtable!(Concat); | ||
|
|
||
| /// Concatenate zero or more expressions into a single ChunkedArray. |
Contributor
There was a problem hiding this comment.
I don't think we need to require that a chunked array is returned, just an array containing all rows of the list of arrays?
vortex-expr/src/exprs/concat.rs
Outdated
| /// lit(Scalar::from(200)), | ||
| /// lit(Scalar::from(300)), | ||
| /// ]); | ||
| /// let concatenated = example.evaluate(&Scope::new(buffer![0].into_array())).unwrap(); |
joseph-isaacs
approved these changes
Oct 9, 2025
blaginin
changed the title
- Update documentation to say concat returns 'a single array' rather than specifically requiring ChunkedArray - Clarify that the result is a ChunkedArray implementation detail - Fix example to use Scope::empty(1) instead of Scope::new() Signed-off-by: blaginin <dima@spiraldb.com>
Signed-off-by: blaginin <dima@spiraldb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
concatexpression that concatenates multiple expressions of the same type into a single ChunkedArray. Each input expression becomes a chunk in the resulting ChunkedArray.Features:
🤖 Generated with Claude Code