fix[duckdb]: handle dict and null correctly #4788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
0ax1
reviewed
Sep 30, 2025
vortex-duckdb/src/exporter/bool.rs
Outdated
| pub(crate) fn new_exporter(array: &BoolArray) -> VortexResult<Box<dyn ColumnExporter>> { | ||
| let validity_mask = array.validity_mask(); | ||
| if validity_mask.all_false() { | ||
| return Ok(invalid::new_exporter( |
Contributor
There was a problem hiding this comment.
invalid or null exporter? It's not invalid to have a validity_mask all false right.
Contributor
Author
There was a problem hiding this comment.
We use all_invalid to mean an all false array, I guess I can change it to that?
Contributor
There was a problem hiding this comment.
Let's go with all invalid then.
| } | ||
|
|
||
| pub(crate) fn new_exporter( | ||
| pub(crate) fn new_exporter_with_flatten( |
Contributor
There was a problem hiding this comment.
I think I'd prefer to only keep on new_exporter func where we pass in the flatten bool explicitly at all times.
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
CodSpeed Performance ReportMerging #4788 will improve performances by 17.45%Comparing Summary
Benchmarks breakdown
Footnotes |
# Conflicts: # vortex-dtype/src/dtype.rs
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
0ax1
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.