Initial version of Masked encoding #4785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
action/benchmark-sql
AdamGS
force-pushed
the
adamg/const-array-validity-thing
branch
from
c3f83e3 to
eb1df8d
Compare
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
github-actions
bot
removed
the
action/benchmark-sql
AdamGS
force-pushed
the
adamg/const-array-validity-thing
branch
from
f450800 to
057916f
Compare
robert3005
reviewed
Sep 30, 2025
robert3005
reviewed
Sep 30, 2025
robert3005
reviewed
Sep 30, 2025
robert3005
reviewed
Sep 30, 2025
robert3005
reviewed
Sep 30, 2025
a10y
reviewed
Sep 30, 2025
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
robert3005
reviewed
Sep 30, 2025
robert3005
reviewed
Sep 30, 2025
robert3005
reviewed
Sep 30, 2025
robert3005
reviewed
Sep 30, 2025
robert3005
approved these changes
Sep 30, 2025
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
We should change this later to allow nullable children
| } | ||
|
|
||
| impl MaskedArray { | ||
| pub fn try_new(child: ArrayRef, validity: Validity) -> VortexResult<Self> { |
Contributor
There was a problem hiding this comment.
Why not return the child array is the validity is all true?
Contributor
There was a problem hiding this comment.
I think it's a little surprising that you call this method and don't end up with a MaskedArray. The caller should know whether they want it which I think means we should assert here that Validity is not NonNullable
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
takeon fsst explodes memory #4784 (comment)Introduces a new
MaskedArrayencoding, which is an array that holds a child with no null values and an external validity array, allowing validity-only operations to be very cheap.The greatest benefit is that together with constant array, it enables us to compress data more aggressively and keep it compact for longer.