-
Notifications
You must be signed in to change notification settings - Fork 130
Pre-allocate data buffer in VarBin::take #4749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6193a26 to
c374349
Compare
Sets a baseline for #4749 Signed-off-by: Adam Gutglick <adam@spiraldb.com>
0c8114a to
7cc7757
Compare
CodSpeed Performance ReportMerging #4749 will improve performances by 26.69%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
The perf improvement is clear now |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
7cc7757 to
9797fd7
Compare
| new_offsets.push(O::zero()); | ||
| let mut current_offset = O::zero(); | ||
|
|
||
| // let mut builder = VarBinBuilder::<u32>::with_data_capacity(data_capacity, indices.len()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sets a baseline for #4749 Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Saves on many re-allocations of the data buffer in the builder. --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Saves on many re-allocations of the data buffer in the builder.