Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Sep 19, 2025

No description provided.

@0ax1 0ax1 added the changelog/feature A new feature label Sep 19, 2025
@0ax1 0ax1 requested review from connortsui20 and gatesn September 19, 2025 13:09
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 16.66667% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.06%. Comparing base (f305580) to head (bed0d01).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-duckdb/build.rs 16.66% 40 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0ax1 0ax1 enabled auto-merge (squash) September 19, 2025 13:22
@0ax1 0ax1 force-pushed the ad/duckdb-debug branch 20 times, most recently from 1ec4d67 to 71a1986 Compare September 19, 2025 14:57
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2025

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71a1986
Status: ✅  Deploy successful!
Preview URL: https://3d7a589e.vortex-93b.pages.dev
Branch Preview URL: https://ad-duckdb-debug.vortex-93b.pages.dev

View logs

Copy link
Contributor

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, but I think it would be best if someone more familiar with DuckDB builds looks at this? Also don't really have time to test this locally myself

@0ax1 0ax1 merged commit 51b9afa into develop Sep 19, 2025
71 checks passed
@0ax1 0ax1 deleted the ad/duckdb-debug branch September 19, 2025 15:19
@connortsui20
Copy link
Contributor

oh it merged haha

@robert3005
Copy link
Contributor

I think we want to run tests with debug build so we get all the assertions

@0ax1
Copy link
Contributor Author

0ax1 commented Sep 19, 2025

I think we want to run tests with debug build so we get all the assertions

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants