Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Sep 19, 2025

This lead to poor DX when running vortex-duckdb unit tests, as lldb stops multiple times on exception breakpoints. It is expected though and correct behavior that DuckDB throws an exception for invalid SQL queries.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from gatesn September 19, 2025 10:25
@0ax1 0ax1 added the changelog/chore A trivial change label Sep 19, 2025
@0ax1 0ax1 enabled auto-merge (squash) September 19, 2025 10:27
@0ax1 0ax1 changed the title chore: drop invalid sql test as it triggers exception breakpoints chore: drop "invalid sql" test as it triggers exception breakpoints Sep 19, 2025
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.11%. Comparing base (f305580) to head (11bc693).
⚠️ Report is 1 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0ax1 0ax1 requested a review from onursatici September 19, 2025 10:36
@0ax1 0ax1 merged commit 54388b2 into develop Sep 19, 2025
37 of 38 checks passed
@0ax1 0ax1 deleted the ad/drop-invalid-sql-test branch September 19, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants