Rename functions in SelectExpr to make API clearer #4690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
requested review from
danking,
gatesn and
joseph-isaacs
and removed request for
gatesn and
joseph-isaacs
AdamGS
commented
Sep 18, 2025
Comment on lines
-55
to
-56
| .fields() | ||
| .fields() |
Contributor
Author
There was a problem hiding this comment.
Mainly to prevent this, I think this is much clearer now.
AdamGS
commented
Sep 18, 2025
|
|
||
| /// Returns the fields of the struct scalar, or None if the scalar is null. | ||
| pub fn fields(&self) -> Option<impl Iterator<Item = Scalar>> { | ||
| pub fn fields(&self) -> Option<impl ExactSizeIterator<Item = Scalar>> { |
Contributor
Author
There was a problem hiding this comment.
just had this and figured its not worth its own PR
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/rename-some-functions-exprs
branch
from
bf0db38 to
e5c7063
Compare
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
robert3005
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately a minor breaking change to the API, but the amount of
fields()functions we have is just too much.