Skip to content

feat: take for sequence array #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danking merged 5 commits into from
Sep 16, 2025
Merged

feat: take for sequence array #4654

danking merged 5 commits into from
Sep 16, 2025

Conversation

@danking
Copy link
Contributor

@danking danking commented Sep 15, 2025

No description provided.

@danking danking requested a review from robert3005 September 15, 2025 20:56
@danking danking added the changelog/feature A new feature label Sep 15, 2025
@danking danking marked this pull request as ready for review September 15, 2025 20:56
@danking danking enabled auto-merge (squash) September 15, 2025 20:57
@codecov
Copy link

codecov bot commented Sep 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.90%. Comparing base (cc426c8) to head (747d187).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/sequence/src/compute/take.rs 86.11% 5 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

robert3005
robert3005 reviewed Sep 15, 2025
View reviewed changes
robert3005
robert3005 reviewed Sep 15, 2025
View reviewed changes
robert3005
robert3005 reviewed Sep 16, 2025
View reviewed changes
robert3005
robert3005 reviewed Sep 16, 2025
View reviewed changes
@danking danking requested a review from robert3005 September 16, 2025 13:47
@danking
feat: take for sequence array
ae29463 
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
remove clippy
765ef89 
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
reuse validity mask
645494b 
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
use from_trusted_len_iter
0fa652c 
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
cargo fmt
747d187 
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking merged commit 1d66c45 into develop Sep 16, 2025
37 checks passed
@danking danking deleted the dk/sequence-take branch September 16, 2025 22:09
AdamGS added a commit that referenced this pull request Sep 17, 2025
@AdamGS
Revert "feat: take for sequence array (#4654)"
8d01179 
This reverts commit 1d66c45.
@AdamGS AdamGS mentioned this pull request Sep 17, 2025
Merged
gatesn pushed a commit that referenced this pull request Sep 17, 2025
@AdamGS
Revert "feat: take for sequence array" (#4674)
7fa7625 
Reverts #4654.

Seems like benchmarks are failing with a related error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danking @robert3005