performance: Avoid intersecting ranges multiple times in scan #4578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danking
requested changes
Sep 9, 2025
Contributor
Author
|
in particular row ranges are always intersected at https://github.com/vortex-data/vortex/pull/4578/files#diff-a2f1b2589c6399cd95128e7320423c6983fd77c7a1497074ac9a105f7c5f8a71L348 |
onursatici
approved these changes
Sep 9, 2025
Contributor
onursatici
left a comment
onursatici
left a comment
There was a problem hiding this comment.
lgtm, all these methods end up calling self.execute and the row_range is intersected there with self.row_range
danking
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Kruszewski github@robertk.io