Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Sep 8, 2025

See https://without.boats/blog/the-scoped-task-trilemma/ for why we can't just have nice things like structured concurrency 😢

I therefore gave up scoping handles with artificial lifetimes and fall back to just holding a phantom lifetime in an open file handle. It still doesn't stop you passing a static future back out of a block_on call... which would then deadlock if you tried to poll it, but hey ho.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 88.67403% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.94%. Comparing base (3206b0f) to head (91c0a59).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-io/src/file/object_store.rs 0.00% 17 Missing ⚠️
vortex-io/src/runtime/single.rs 81.08% 7 Missing ⚠️
vortex-io/src/runtime/current.rs 70.58% 5 Missing ⚠️
vortex-io/src/runtime/smol.rs 40.00% 3 Missing ⚠️
vortex-io/src/runtime/tokio.rs 85.71% 3 Missing ⚠️
vortex-io/src/file/mod.rs 84.61% 2 Missing ⚠️
vortex-io/src/file/std_file.rs 80.00% 2 Missing ⚠️
vortex-io/src/runtime/tests.rs 98.98% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robert3005
Copy link
Contributor

How did you find that post? It's sad that it explains our problem precisely. !Leak in rust would have been cool.

@gatesn
Copy link
Contributor Author

gatesn commented Sep 8, 2025

@onursatici sent it to me. There's a few other explanations on the various runtime issues, e.g. Tokio's

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added changelog/chore A trivial change changelog/fix A bug fix and removed changelog/chore A trivial change labels Sep 8, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 8, 2025

CodSpeed Performance Report

Merging #4572 will not alter performance

Comparing ngates/runtime-transmutes (91c0a59) with develop (7156645)

Summary

✅ 1351 untouched benchmarks

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) September 9, 2025 09:56
@gatesn gatesn requested a review from robert3005 September 9, 2025 10:04
@gatesn gatesn merged commit 11e16c1 into develop Sep 9, 2025
39 checks passed
@gatesn gatesn deleted the ngates/runtime-transmutes branch September 9, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants