-
Notifications
You must be signed in to change notification settings - Fork 130
Remove transmutes from vortex-io/runtime #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
How did you find that post? It's sad that it explains our problem precisely. !Leak in rust would have been cool. |
|
@onursatici sent it to me. There's a few other explanations on the various runtime issues, e.g. Tokio's |
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
CodSpeed Performance ReportMerging #4572 will not alter performanceComparing Summary
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
See https://without.boats/blog/the-scoped-task-trilemma/ for why we can't just have nice things like structured concurrency 😢
I therefore gave up scoping handles with artificial lifetimes and fall back to just holding a phantom lifetime in an open file handle. It still doesn't stop you passing a static future back out of a block_on call... which would then deadlock if you tried to poll it, but hey ho.