Skip to content

Conversation

@danking
Copy link
Contributor

@danking danking commented Sep 6, 2025

No description provided.

@danking danking requested a review from gatesn September 6, 2025 15:57
@danking danking marked this pull request as ready for review September 6, 2025 15:57
@danking danking enabled auto-merge (squash) September 6, 2025 15:57
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking force-pushed the dk/fix-is-sorted-nullable-bool branch from 302a980 to 300ac82 Compare September 6, 2025 15:57
@danking danking added the changelog/fix A bug fix label Sep 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 6, 2025

CodSpeed Performance Report

Merging #4555 will degrade performances by 15.4%

Comparing dk/fix-is-sorted-nullable-bool (300ac82) with develop (425b55a)

Summary

❌ 1 regressions
✅ 1350 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
encode_specialized 1.1 ms 1.3 ms -15.4%

@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.62%. Comparing base (425b55a) to head (300ac82).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/compute/is_sorted.rs 0.00% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danking danking merged commit 5fed078 into develop Sep 6, 2025
43 of 45 checks passed
@danking danking deleted the dk/fix-is-sorted-nullable-bool branch September 6, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants