Skip to content

Conversation

@robert3005
Copy link
Contributor

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 enabled auto-merge (squash) September 5, 2025 16:43
@robert3005 robert3005 added the changelog/fix A bug fix label Sep 5, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 5, 2025

CodSpeed Performance Report

Merging #4546 will improve performances by 10.68%

Comparing rk/issorted (2865fc1) with develop (d0e73e7)

Summary

⚡ 2 improvements
✅ 1349 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
take_search[(0.005, 0.5)] 325.9 µs 294.7 µs +10.57%
take_search[(0.005, 1.0)] 629.4 µs 568.6 µs +10.68%

@robert3005 robert3005 merged commit 5722312 into develop Sep 5, 2025
43 of 45 checks passed
@robert3005 robert3005 deleted the rk/issorted branch September 5, 2025 16:54
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 62.18487% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.59%. Comparing base (dbbd62f) to head (2865fc1).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...rtex-array/src/arrays/chunked/compute/is_sorted.rs 0.00% 12 Missing ⚠️
encodings/dict/src/compute/is_sorted.rs 0.00% 11 Missing ⚠️
vortex-array/src/arrays/bool/compute/is_sorted.rs 16.66% 10 Missing ⚠️
...ortex-array/src/arrays/varbin/compute/is_sorted.rs 0.00% 8 Missing ⚠️
encodings/runend/src/compute/is_sorted.rs 0.00% 2 Missing ⚠️
vortex-array/src/arrays/extension/compute/mod.rs 50.00% 1 Missing ⚠️
vortex-array/src/compute/is_sorted.rs 97.43% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants