Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Sep 5, 2025

Tracking Issue: #4372

See title. This PR is mostly tests.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 5, 2025

CodSpeed Performance Report

Merging #4545 will degrade performances by 18.8%

Comparing ct/fsl-impls (4a3bcdb) with develop (b15cca0)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 1349 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
new_bp_prim_test_between[i16, 2048] 42.7 µs 36.6 µs +16.56%
new_raw_prim_test_between[i32, 2048] 25.5 µs 31.4 µs -18.8%

@connortsui20 connortsui20 requested a review from gatesn September 5, 2025 16:21
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.99%. Comparing base (696233a) to head (4a3bcdb).
⚠️ Report is 4 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robert3005 robert3005 merged commit d0e73e7 into develop Sep 5, 2025
40 of 41 checks passed
@robert3005 robert3005 deleted the ct/fsl-impls branch September 5, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants