fix: #4503 #4504
Merged
fix: #4503 #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel King <dan@spiraldb.com>
danking
force-pushed
the
dk/test-pco-with-nullable
branch
from
757756d to
fb837a5
Compare
a10y
reviewed
Sep 3, 2025
Comment on lines
+48
to
+55
| fn test_compress_decompress_big() { | ||
| let array = PrimitiveArray::from_option_iter([None, Some(1)]); | ||
| let compressed = PcoArray::from_primitive(&array, 3, 0).unwrap(); | ||
| assert_eq!(compressed.scalar_at(0), Scalar::null_typed::<i32>()); | ||
| assert_eq!(compressed.scalar_at(1), Scalar::from(Some(1))); | ||
| let decompressed = compressed.decompress(); | ||
| assert_eq!(decompressed.scalar_at(0), Scalar::null_typed::<i32>()); | ||
| assert_eq!(decompressed.scalar_at(1), Scalar::from(Some(1))); |
Contributor
There was a problem hiding this comment.
Which one should panic? there are 4 different asserts here
Contributor
Author
There was a problem hiding this comment.
It's actually the decompression that panics. I'll add a message check
Contributor
Author
There was a problem hiding this comment.
Actually I found the fix.
Signed-off-by: Daniel King <dan@spiraldb.com>
danking
added
changelog/fix
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4503
Pco mistakenly used the number of values rather than the number of valid values.