Dispatch each I/O request #4464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
onursatici
added
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: TPC-H SF=1 on NVMETable of Results
|
Contributor
Benchmarks: TPC-H SF=1 on S3Table of Results
|
Contributor
Benchmarks: Statistical and Population GeneticsTable of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMETable of Results
|
robert3005
pushed a commit
that referenced
this pull request
Sep 2, 2025
…rsion (#4481) This would cause a panic in arrow when attempting to create a list when the preferred conversion resulted in a different element array type due to the different types. This commit also simplifies the input arguments so that preferred type conversion never has access to the canonical arrow type. Ran into this while testing #4464 Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
a10y
approved these changes
Sep 3, 2025
onursatici
approved these changes
Sep 3, 2025
lwwmanning
approved these changes
Sep 3, 2025
Contributor
Benchmarks: compressTable of Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at short-term fix for #4400
The coalescing driver was spawned as a single task, and so landed on a single thread of the I/O dispatcher regardless of how many threads you gave it. This PR spawns each read request to allow other threads a chance to play ball.
The reason the Polars patch doesn't work is that we need to continue to dispatch work in order to provide a Tokio runtime within non-Tokio clients, such as DuckDB. This is a bigger change as part of #4406