VortexExpr VTables #3713
Merged
VortexExpr VTables #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Contributor
|
If we're doing this, we should probably revive #3492 as well and just push more of the public API to go through the session object, so the session owns all of the vtables and everything that needs to do dynamic dispatch borrows from it |
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
CodSpeed Performance ReportMerging #3713 will not alter performanceComparing Summary
|
Contributor
"Guys, @gatesn is back" |
lwwmanning
added
changelog/feature
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Contributor
Author
|
Or we go in the direction of making ComputeFns extensible, and not expressions... #3453 |
robert3005
reviewed
Jul 8, 2025
|
|
||
| #[derive(Debug, Clone, Eq, Hash)] | ||
| #[allow(clippy::derived_hash_with_manual_eq)] | ||
| #[derive(Debug, Clone, Hash)] |
robert3005
reviewed
Jul 8, 2025
| use crate::{ExprRef, IntoExpr, VTable}; | ||
|
|
||
| pub type ExprId = ArcRef<str>; | ||
| pub type ExprEncodingRef = ArcRef<dyn ExprEncoding>; |
Contributor
There was a problem hiding this comment.
The encoding for an array made a logical sense in my mind, encoding for expression is very forced analogy. We can rename it later
robert3005
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the same vtable machinery as arrays and layouts already use. It uses the "Encoding" naming scheme from arrays and layouts. I don't particularly like it, but it's consistent. Open to renames later.
Further, adds an expression registry to the Vortex session that will be used for deserialization.
Expressions only decide their "options" serialization. So in theory, can support many container formats, not just proto, provided each expression can deserialize their own options format.