-
Notifications
You must be signed in to change notification settings - Fork 135
Description
Right now, neither IsSortedKernel nor MinMaxKernel have been implemented for any of List, ListView, and FixedSizeList.
This would require lexicographic comparisons between list scalars.
The implementations are all located under vortex-array/src/arrays, in the respective compute directories (i.e., vortex-array/src/arrays/fixed_size_list/compute/is_sorted.rs).
Right now they all return Ok(None), so we want them to return Ok(Some(true)) if they are in lexicographic order.
The naive way to do this is to make some compare function that takes two ListScalars and manually iterate over each Array type with scalar_at(i). That would also need to handle nulls.
I can't really think of a more efficient way to do this (unless we added another compute function for lexicographic comparisons between 2 array [slices]).
I'm creating this issue just so it is not only discoverable through TODOs in the codebase, and I'm assigning it to people who had those TODOs there
If you're not a Vortex contributor and you would like to try this out, please let us know!