You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Well, the AST structure should be stable for both the POSIX and the bash grammars.
The API will be changed soon to solve #43. The change will not be an easy one, but the change in public API signature will be small: parse will return a promise of the AST, and in the option argument, resolvePath callback would have to return a promise, while execCommand and execShellScript.
According to me, we can try the thing in a cash branch. I saw you are going to create a branch for v2 of cash: we can even use that...
There is a dependent package built by @substack on npm from some time now: https://www.npmjs.com/package/falafel-bash, but it's based on an older version of bash-parser.
I made a PR there to update the bash-parser version, but it's still unmerged by now...
Activity
parro-it commentedon May 31, 2017
Hi @dthree, nice to see you on the road again 😸
Well, the AST structure should be stable for both the POSIX and the bash grammars.
The API will be changed soon to solve #43. The change will not be an easy one, but the change in public API signature will be small:
parsewill return a promise of the AST, and in the option argument,resolvePathcallback would have to return a promise, whileexecCommandandexecShellScript.According to me, we can try the thing in a
cashbranch. I saw you are going to create a branch for v2 of cash: we can even use that...There is a dependent package built by @substack on npm from some time now: https://www.npmjs.com/package/falafel-bash, but it's based on an older version of bash-parser.
I made a PR there to update the bash-parser version, but it's still unmerged by now...
dthree commentedon Jun 1, 2017
Great!
API change doesn't seem to be too big a deal.
His package is pretty basic, so not sure that we should worry too much about getting it merged.
I'm actually looking at this for Vorpal 2.0!