Skip to content

Quote removal should be configurable #29

Description

@parro-it

If expansion callback are not passed in options, quote removal should be avoid to allow a correct expansion on user side.

Activity

  1. parro-it commented on Sep 13, 2016

    @parro-it
    CollaboratorAuthor

    Actually, we perform quote removal only if all of the substitutions found in a word are solved. Do you think there is still need of an option to disable quote removal also when there are no subst?

  2. piranna commented on Sep 13, 2016

    @piranna
    Collaborator

    I think they should be removed in all cases when possible also if not all of them has been replaced, because quotes only function is to work as delimiters and they have already done their purposse. On the other hand, a flag disabled by default to remove them is not bad, too.

  3. parro-it commented on Oct 11, 2016

    @parro-it
    CollaboratorAuthor

    quotes only function is to work as delimiters and they have already done their purpose

    If the parser remove quotes even when it didn't perform substitution, the caller may not be able to perform them by itself, because you lose the information if the word or part of it are quoted (e.g. if it's quoted between single quotes, substitution should not occcur)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions