-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread sanitizer to test #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, as mentioned in the linked ticket… I'm hesitant to merge it right now until we know if the reported failure is a false positive or not and until there's a solution. But once once that is solved, I'm happy to have it.
Nice that the MacOS one works. But the UBuntu one would keep the CI red all the time, so it's not particularly useful. Do you agree if I cherry-pick that one and leave the rest? Or do you want to create a cleaned-up branch with that one yourself? |
I will remove the ubuntu thread sanitizer test since it is likely to be just false positive and really isn't helpful. |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 86.25% 86.34% +0.09%
==========================================
Files 18 18
Lines 1091 1091
==========================================
+ Hits 941 942 +1
+ Misses 150 149 -1
|
This PR adds thread sanitizer to github workflow CI.
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com