Document T must be sized and why #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepmaster
approved these changes
Apr 12, 2020
| //! | ||
| //! // But this does: | ||
| //! let data: ArcSwap<Box<[u8]>> = ArcSwap::from_pointee(Box::new([1, 2, 3])); | ||
| //! # drop(data); |
There was a problem hiding this comment.
To avoid an unused variable warning. I turn warning into errors in code examples, to avoid unidiomatic code being left in when the coding standards change over time. It's hidden line, though.
src/lib.rs
Outdated
| //! # Limitations | ||
| //! | ||
| //! This currently works only for `Sized` types. Unsized types have „fat pointers“, which are twice | ||
| //! as large as the normal ones. The [AtomicPtr] doesn't support them. One could use something like |
There was a problem hiding this comment.
Could use code syntax for AtomicPtr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27.
@shepmaster, do you want to have a look?