Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate an efficient way to drop pairs #58

Open
cipriancraciun opened this issue May 9, 2018 · 0 comments
Open

Investigate an efficient way to drop pairs #58

cipriancraciun opened this issue May 9, 2018 · 0 comments
Labels
code-builtins feature implementation optimization
Milestone
Backlog

Comments

@cipriancraciun
Copy link
Member

The "default" variant in which Rust handles the dropping is made in a recursive manner, thus it will yield an overflow stack abort. The "custom" Drop::drop implementation currently elides this overflow by implementing an "iterative drop", which unfortunately blows the efficiency by a factor of 10...

At the moment the iterative drop is disabled by default, thus the default recursive behaviour is used... (One should not create lists longer than 20k pairs.)
@cipriancraciun cipriancraciun added this to the Release 0.2.0 milestone May 9, 2018
cipriancraciun added a commit that referenced this issue May 9, 2018
@cipriancraciun
[values] Try to implement "iterative drop" for pairs to elude the `ov…
0bc7d8f 
…erflow stack` aborts; however due to efficiency it is currently disabled [#58]
@cipriancraciun cipriancraciun modified the milestones: Release 0.2.0, Backlog May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-builtins feature implementation optimization
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@cipriancraciun