Skip to content

Conversation

lbm-services
Copy link

Why you should support webp: https://developers.google.com/speed/webp?hl=en
Use date instead of year according to the mpd format standard definition!
https://www.musicpd.org/doc/mpc/html/

@volumio
Copy link
Owner

volumio commented Jul 21, 2023

Thanks for your contriubution.

Here are my remarks:

  • Please send 2 distincts PRs (1 PR = 1 feature)
  • We never encountered webp cover arts, that's why its not included. but it's worth adding. However, please edit the code so it treats only user files and not others (like the tiny art)
  • While it's correct that date is consistent with mpd format, it's not with our fronted, so this also should be harmozied. IMHO this can be skipped, unless you have a strong motivation to provide

@lbm-services
Copy link
Author

While it's correct that date is consistent with mpd format, it's not with our fronted, so this also should be harmozied. IMHO this can be skipped, unless you have a strong motivation to provide

Yes, the motivation is that it's not consistent with MY frontend ;-)
When I started working on it, your frontend did not show the album year/date at all (approx. 3 yrs ago).
(I will upload my vue frontend code as soon as I solved some issues with migrating from webpack to vite. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants