Global Reentrancy Modifier Changes#196
Merged
ElliotFriedman merged 4 commits intofeat/pcv-oracle-refactorfrom Feb 10, 2023
Merged
Global Reentrancy Modifier Changes#196ElliotFriedman merged 4 commits intofeat/pcv-oracle-refactorfrom
ElliotFriedman merged 4 commits intofeat/pcv-oracle-refactorfrom
Conversation
ElliotFriedman
added a commit
that referenced
this pull request
Feb 10, 2023
* checkpoint * fix unit tests * fix failing integration tests * fix failing unit tests * unit tests fixed * rename functions * remove getTotalLastRecordedPcv * update tests * increase test coverage * add pcv oracle hook to mock, increase unit test coverage * add additional tests and fix existing ones * import ordering * update mock and fix units * PCV Guardian todo * remove outdated todo * oracle invalid comment * oracle interface addition * Global Reentrancy Modifier Changes (#196) * remove reentrancy checks when lock is set to address 0 * add lock tests * add additional reentrancy tests when lock is set to 0 * update comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreRefV2 changes to ignore reentrancy lock and checks when the global reentrancy lock is set to 0.