support multiturn prompt for SFT #635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
seanexp
commented
Mar 17, 2025
| print(f'self.prompts={self.prompts}') | ||
| raise | ||
| self.prompts = self.prompts.tolist() | ||
| self.prompts = self.prompts.squeeze().tolist() |
There was a problem hiding this comment.
When using pandas==2.2.2, this line raises an error complaining DataFrame does not have .tolist() method. So I added .squeeze() method.
seanexp
commented
Mar 17, 2025
| loss_mask[:min(prompt_length, loss_mask.size(0)) - 1] = 0 | ||
| # mask out the last token in response | ||
| loss_mask[min(prompt_length + response_length, loss_mask.size(0)) - 1] = 0 | ||
| # loss_mask[min(prompt_length + response_length, loss_mask.size(0)) - 1] = 0 |
There was a problem hiding this comment.
I have no idea why eos_token masking is needed so I erased the line. I'll revert this if the masking is needed.
There was a problem hiding this comment.
@vermouth1992 could u help take a look?
|
I am aware of this PR, but I add this PR because the PR is WIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about
Current implementation of SFTDataset only supports single turn prompt. This PR adds support for multi-turn prompt which is in messages format.