Skip to content

Conversation

@kaln27
Copy link
Contributor

@kaln27 kaln27 commented Jul 11, 2025

What does this PR do?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the checkpoint saving logic to handle cases where generation_config.json is missing and adds support for glm4v in the FLOPs counter.

My main feedback is on the fsdp_checkpoint_manager.py file. The current implementation for checking the existence of generation_config.json introduces a potential race condition. I've suggested a more robust try-except pattern to prevent potential crashes.

The changes in flops_counter.py look good.

I noticed the PR title mentions replacing AutoModelForVision2Seq with AutoModelFotImageTextToText, but this change doesn't seem to be included in the diffs. You might want to double-check if that was intended for this PR.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2025

CLA assistant check
All committers have signed the CLA.

@kaln27 kaln27 marked this pull request as ready for review July 11, 2025 06:36
@kaln27 kaln27 changed the title [misc] fix: Use AutoModelFotImageTextToText instead of AutoModelForVision2Seq [misc] fix: Use AutoModelForImageTextToText instead of AutoModelForVision2Seq Jul 11, 2025
@kaln27
Copy link
Contributor Author

kaln27 commented Jul 28, 2025

@eric-haibin-lin Hi eric. Could you review this PR? Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants