[misc] fix: grpo kl loss should be add when do minimization #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PeterSH6
commented
Feb 1, 2025
PeterSH6
commented
- As titled
vermouth1992
approved these changes
Feb 1, 2025
as12138
pushed a commit
to as12138/verl
that referenced
this pull request
Feb 20, 2025
wangyuchen333
pushed a commit
to wangyuchen333/verl
that referenced
this pull request
Apr 25, 2025
histmeisah
pushed a commit
to SJTU-IAAR/verl
that referenced
this pull request
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.