Skip to content

fix: info show when local docker build fail #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
innsd merged 1 commit into from
Dec 31, 2025
Merged

fix: info show when local docker build fail #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions agentkit/toolkit/builders/local_docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,6 @@ def generate_dockerfile_content() -> str:
)
else:
error_msg = "Docker build failed"
if build_logs:
error_msg = "\n".join(build_logs[-10:])
return BuildResult(
success=False,
error=error_msg,
Expand Down
6 changes: 3 additions & 3 deletions agentkit/toolkit/docker/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,18 +279,18 @@ def build_image(
)
build_logs.append(f"ERROR: {error_msg}")
logger.error(error_msg)
return False, "\n".join(build_logs), None
return False, build_logs, None

try:
image = self.client.images.get(full_image_name)
image_id = image.id
logger.info(
f"Image build successful: {full_image_name} (ID: {image_id})"
)
return True, "\n".join(build_logs), image_id
return True, build_logs, image_id
except Exception as e:
logger.warning(f"Build successful but couldn't get image ID: {str(e)}")
return True, "\n".join(build_logs), None
return True, build_logs, None

except Exception as e:
error_msg = f"Image build failed: {str(e)}"
Expand Down