refactor: unify async execution utilities into run_async#75
Merged
Conversation
- Create centralized run_async() in openviking/utils/async_utils.py - Remove duplicate _run_async from session.py - Remove duplicate run_coroutine_sync from observers/async_utils.py - Replace asyncio.run() calls in sync_client.py with run_async - Update observers to use the unified run_async utility - Update tests and documentation for new observer API
kkkwjx07
approved these changes
Feb 5, 2026
MaojiaSheng
pushed a commit
that referenced
this pull request
Feb 6, 2026
* feat: 增加对私部vikingdb的支持 * feat: add search_with_sparse_logit_alpha (#71) * refactor: Refactor S3 configuration structure and fix Python 3.9 compatibility issues (#73) * refactor: Refactor S3 configuration structure and fix Python 3.9 compatibility issues - Extract S3-related configurations from AGFSConfig into a new S3Config class - Update agfs_manager.py to use the new S3Config structure - Modify test_config_validation.py to adapt to the new configuration structure - Update configuration example files to reflect the new configuration structure - Fix Python 3.9 compatibility issue in embedding_queue.py by replacing `EmbeddingMsg | None` with `Optional[EmbeddingMsg]` * fix: validate_config validate error * fix: fix ci (#74) * refactor: unify async execution utilities into run_async (#75) - Create centralized run_async() in openviking/utils/async_utils.py - Remove duplicate _run_async from session.py - Remove duplicate run_coroutine_sync from observers/async_utils.py - Replace asyncio.run() calls in sync_client.py with run_async - Update observers to use the unified run_async utility - Update tests and documentation for new observer API * 原生部署的vikingdb由外部来管理 --------- Co-authored-by: kkkwjx <zhoujiahui.01@bytedance.com> Co-authored-by: baojun-zhang <zhangbaojun.1@bytedance.com> Co-authored-by: qin-ctx <qinhaojie.exe@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refactor: unify async execution utilities into run_async
Related Issue
Fixes #63
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes