Skip to content

Fix: Repair import openviking Segmentation Fault on Anaconda#56

Closed
Tsan1024 wants to merge 3 commits intovolcengine:mainfrom
Tsan1024:main
Closed

Fix: Repair import openviking Segmentation Fault on Anaconda#56
Tsan1024 wants to merge 3 commits intovolcengine:mainfrom
Tsan1024:main

Conversation

@Tsan1024
Copy link

@Tsan1024 Tsan1024 commented Feb 5, 2026

Description

Related Issue

#42

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

image
  • remove
if(APPLE)
  set(CMAKE_OSX_DEPLOYMENT_TARGET "10.15" CACHE STRING "Minimum macOS deployment version")
endif()
  • change
 change pybind11_add_module from shared to module

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

image

Additional Notes

A successful compilation alone is insufficient; it is imperative to perform pip install in the actual runtime environment, conduct an import check, and additionally add this import check step in GitHub Actions.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ tangshan.10
❌ Tsan1024


tangshan.10 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.


if sys.platform == "darwin":
cmake_args.append("-DCMAKE_OSX_DEPLOYMENT_TARGET=10.15")
cmake_args.append("-DCMAKE_OSX_DEPLOYMENT_TARGET=12.1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种会导致老版本 mac 用不了吗

Copy link
Author

@Tsan1024 Tsan1024 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好问题,看到一种说话是推荐-DCMAKE_OSX_DEPLOYMENT_TARGET=11.0,Apple Silicon看起来是从11.0开始

@Jay-Chou118
Copy link
Contributor

Jay-Chou118 commented Feb 5, 2026

我试着修改验证一下,不过我的mac版本也不是很老

@qin-ctx
Copy link
Collaborator

qin-ctx commented Feb 5, 2026

fixed by #62

@qin-ctx qin-ctx closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants