Fix: Repair import openviking Segmentation Fault on Anaconda#56
Closed
Tsan1024 wants to merge 3 commits intovolcengine:mainfrom
Closed
Fix: Repair import openviking Segmentation Fault on Anaconda#56Tsan1024 wants to merge 3 commits intovolcengine:mainfrom
Tsan1024 wants to merge 3 commits intovolcengine:mainfrom
Conversation
|
tangshan.10 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ZaynJarvis
reviewed
Feb 5, 2026
|
|
||
| if sys.platform == "darwin": | ||
| cmake_args.append("-DCMAKE_OSX_DEPLOYMENT_TARGET=10.15") | ||
| cmake_args.append("-DCMAKE_OSX_DEPLOYMENT_TARGET=12.1") |
Author
There was a problem hiding this comment.
好问题,看到一种说话是推荐-DCMAKE_OSX_DEPLOYMENT_TARGET=11.0,Apple Silicon看起来是从11.0开始
Contributor
|
我试着修改验证一下,不过我的mac版本也不是很老 |
Collaborator
|
fixed by #62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#42
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes
A successful compilation alone is insufficient; it is imperative to perform pip install in the actual runtime environment, conduct an import check, and additionally add this import check step in GitHub Actions.