fix(sdk-typescript): distinguish cancellation from timeout#3369
Open
AaronZ345 wants to merge 1 commit into
Open
fix(sdk-typescript): distinguish cancellation from timeout#3369AaronZ345 wants to merge 1 commit into
AaronZ345 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TypeScript SDK currently maps two different events to the same error:
AbortSignal.Both become
DEADLINE_EXCEEDED, so callers cannot tell whether a request timed out or was intentionally cancelled. Retry code may then retry work the application deliberately stopped.This change records which source aborted the internal controller. Timer expiry remains
DEADLINE_EXCEEDED; caller cancellation now returns the standard OpenVikingABORTEDcode.Human Involvement
Related Issue
No linked issue.
Type of Change
Changes Made
DEADLINE_EXCEEDEDand a timeout-specific message for timer expiry.ABORTEDfor both pre-aborted signals and cancellation while a request is in flight.Testing
Commands run from
sdk/typescript:npm test— 30 passednpm run typecheck— passednpm run format:check— passedgit diff --check— passedChecklist
Screenshots
Not applicable.
Additional Notes
No request API changes are required. Existing callers still pass an ordinary
AbortSignal; only the resulting error code is corrected.