refactor(memory): disable tool/skill extraction and retire compressor V2#3346
Draft
chenjw wants to merge 2 commits into
Draft
refactor(memory): disable tool/skill extraction and retire compressor V2#3346chenjw wants to merge 2 commits into
chenjw wants to merge 2 commits into
Conversation
chenjw
force-pushed
the
fix/issue-3292-disable-tool-skill-memory
branch
from
July 18, 2026 16:47
21cdff5 to
d68b4e4
Compare
chenjw
force-pushed
the
fix/issue-3292-disable-tool-skill-memory
branch
from
July 18, 2026 17:07
d68b4e4 to
0f3e750
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Temporarily disable ordinary
toolsandskillsmemory extraction, make SessionCompressorV3 the only session extraction implementation, and remove SessionCompressorV2.V3 now owns the prepared extraction context, memory-type whitelist initialization, public error behavior, and extraction telemetry. Trajectory, experience, and optional executable session-skill training remain case-driven: when ordinary extraction produces no case, none of those artifacts are trained.
Human Involvement
Related Issue
Fixes #3292
Type of Change
Changes Made
tools.yamlandskills.yamlmemory schemas toenabled: falsewhile retaining disabled-schema introspection.SessionCompressorV3.extract_long_term_memories()and preserve case-driven trajectory/experience/executable-skill training.The V2 deletion intentionally does not provide an import compatibility alias, so external imports of
openviking.session.compressor_v2will fail.Testing
Focused verification on the final branch:
68 passedfor V3 extraction, registry disablement, memory diff/config coverage, and V3-only session routing.git diff --check origin/main...HEADpasses.The broader adjacent server/memory suites are not fully green in the current local environment. Observed failures include an installed AGFS binding without
glob_directory, background archive tasks exceeding the tests' 10-second timeout, and existing output-language expectation mismatches. This is why the PR is opened as Draft.Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
The branch contains exactly two commits: one for temporarily disabling ordinary tool/skill extraction, and one for the V3 migration and V2 retirement.